search

prestaconcept / PrestaSitemapBundle

A symfony bundle that provides tools to build a rich application sitemap. The main goals are : simple, no databases, various namespace (eg. google image), respect constraints etc.
MIT License
355 stars 102 forks source link

Add missing Content-Type text/xml header #214

Closed fnowacki closed 4 years ago

fnowacki commented 4 years ago

Currently, without dumping sitemap, controller response serving text/html Content-Type header. This fix setting up correct header for xml sitemap.

yann-eugone commented 4 years ago

Hey ! This is a great catch ! Thank you.

Can you please add some assertions to the associated test ?

fnowacki commented 4 years ago

@yann-eugone done :)

yann-eugone commented 4 years ago

Thank you for this !

fnowacki commented 4 years ago

@yann-eugone do you plan release fix for current 1.7 version?

yann-eugone commented 4 years ago

It was not in my roadmap. But as it is really small, and you developed it in the first place, I can cherry-pick it if you want.

Le lun. 21 oct. 2019 à 14:50, Filip Nowacki notifications@github.com a écrit :

@yann-eugone https://github.com/yann-eugone do you plan release fix for current 1.7 version?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/prestaconcept/PrestaSitemapBundle/pull/214?email_source=notifications&email_token=AAJ6KHUX2KCEWFW5REENYR3QPWQP3A5CNFSM4JB6ZMTKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEB2GN5Q#issuecomment-544499446, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJ6KHTZN4JENRJ3GW4TAU3QPWQP3ANCNFSM4JB6ZMTA .

fnowacki commented 4 years ago

I will be grateful :)