search

prestaconcept / PrestaSitemapBundle

A symfony bundle that provides tools to build a rich application sitemap. The main goals are : simple, no databases, various namespace (eg. google image), respect constraints etc.
MIT License
355 stars 102 forks source link

[WIP] Added test assertions to ensure routing is configured the good way #223

Closed yann-eugone closed 4 years ago

yann-eugone commented 4 years ago

As an addition to #221 & #222 this PR add some assertion that should cause tests to fail at the moment.

When #222 will be merged, this PR will be rebased, and tests should be green again.

ostrolucky commented 4 years ago

Why not functional tests like docs suggest? https://symfony.com/doc/current/testing.html#your-first-functional-test It looks less error prone, covers wider array of things and are more concise

yann-eugone commented 4 years ago

Because it requires more work, I'm currently working on a test refactor (as promised in #222) this is just a hack that is to be replaced in a few weeks.

yann-eugone commented 4 years ago

It was harder than expected (private services access + deprecations) but this is it :