search

prestaconcept / PrestaSitemapBundle

A symfony bundle that provides tools to build a rich application sitemap. The main goals are : simple, no databases, various namespace (eg. google image), respect constraints etc.
MIT License
355 stars 102 forks source link

Add DumpSitemapMessage for messenger integration #237

Closed norkunas closed 4 years ago

norkunas commented 4 years ago

I am not sure which messenger version should be picked?

yann-eugone commented 4 years ago

Hi @norkunas ! First of all, thank you for this nice integration idea. I'll start having a look at your code today, so I can give you some feedback.

norkunas commented 4 years ago

And for the tests - what path should we follow? Add a flag on travis to remove the messenger dependency on the unsupported Symfony versions?

norkunas commented 4 years ago

I've managed to make build green, except that travis is red because of deprecations. But I'm not sure this is the best way :)

norkunas commented 4 years ago

Updated.

norkunas commented 4 years ago

More deprecations are coming from the symfony itself. So either we should ignore them or set SYMFONY_DEPRECATIONS_HELPER="max[total]=11"

yann-eugone commented 4 years ago

Github actions was added to the bundle as a replacement to Travis, but we keep both for a period.

For what I've seen, these deprecations are not direct. Will fix this in an other PR (will end up with some SYMFONY_DEPRECATIONS_HELPER env value).

Thank you for this good job here ! :)