search

prestaconcept / PrestaSitemapBundle

A symfony bundle that provides tools to build a rich application sitemap. The main goals are : simple, no databases, various namespace (eg. google image), respect constraints etc.
MIT License
355 stars 102 forks source link

Fix symfony 5.1 deprecations #239

Closed norkunas closed 4 years ago

norkunas commented 4 years ago

Fix these deprecations:

  6x: Since symfony/framework-bundle 5.1: Using type "Symfony\Component\Routing\RouteCollectionBuilder" for argument 1 of method "Presta\SitemapBundle\Tests\Integration\Kernel:configureRoutes()" is deprecated, use "Symfony\Component\Routing\Loader\Configurator\RoutingConfigurator" instead.
    3x in HttpTest::testAccessSitemapWithHttp from Presta\SitemapBundle\Tests\Integration\Tests
    2x in CliTest::testDumpSitemapUsingCLI from Presta\SitemapBundle\Tests\Integration\Tests
    1x in CliTest::testGzipLinksArePreservedOnPartialDump from Presta\SitemapBundle\Tests\Integration\Tests

  5x: Since symfony/http-foundation 5.1: The "Symfony\Component\HttpFoundation\Response::create()" method is deprecated, use "new Symfony\Component\HttpFoundation\Response()" instead.
    3x in HttpTest::testAccessSitemapWithHttp from Presta\SitemapBundle\Tests\Integration\Tests
    1x in SitemapControllerTest::testIndexSuccesful from Presta\SitemapBundle\Tests\Unit\Controller
    1x in SitemapControllerTest::testSectionSuccessful from Presta\SitemapBundle\Tests\Unit\Controller

  1x: Since symfony/framework-bundle 5.1: Not setting the "framework.router.utf8" configuration option is deprecated, it will default to "true" in version 6.0.
    1x in CliTest::testDumpSitemapUsingCLI from Presta\SitemapBundle\Tests\Integration\Tests

  1x: Since symfony/routing 5.1: The "Symfony\Component\Routing\RouteCollectionBuilder" class is deprecated, use "Symfony\Component\Routing\Loader\Configurator\RoutingConfigurator" instead.
    1x in CliTest::testDumpSitemapUsingCLI from Presta\SitemapBundle\Tests\Integration\Tests
norkunas commented 4 years ago

Nice catch !

Maybe we can switch both .github/workflows/ci.yml & .travis.yml to symfony 5.1 instead of 5.0 ?

Yeah, okay :)

norkunas commented 4 years ago

Friendly ping :)

yann-eugone commented 4 years ago

Looks like I forgot this one... Thank you for reminding me to merge it ! :)