A symfony bundle that provides tools to build a rich application sitemap. The main goals are : simple, no databases, various namespace (eg. google image), respect constraints etc.
As suspected in #258 Dumper service may not call cleanup if an exception is thrown during dump.
This wrap (almost) the whole dump function with a try / finally so cleanup is always called.
After adding the assertTempFilesWereRemoved in DumperTest, some tests were already failing (testExistingInvalidSitemap).
I still decided to add a dedicated test case to handle a throwing exception listener.
As suspected in #258
Dumperservice may not callcleanupif an exception is thrown duringdump.This wrap (almost) the whole dump function with a
try / finallysocleanupis always called.After adding the
assertTempFilesWereRemovedinDumperTest, some tests were already failing (testExistingInvalidSitemap). I still decided to add a dedicated test case to handle a throwing exception listener.