search

prestarocket-agence / classic-rocket

Classic Rocket is a rework of "classic theme". It has been built keeping in mind : performance, accessibility and SEO.
https://demoprestashop.prestarocket.com/
Other
230 stars 127 forks source link

Coding style #102

Open redactuk opened 4 years ago

redactuk commented 4 years ago

Really like your work on this template. We've used it as base for new theme recently. But to avoid issues when we compare changes in future updates, are you using specific coding style settings e.g. an .editorconfig? In particular we would like to ensure we sync indent size. Thanks

prestarocket commented 4 years ago

thx !! no .editorconfig, any advice ?

redactuk commented 4 years ago

When it comes to indent size developers always seem to disagree, so my advice would be go with the default for Prestashop - assuming they themselves stick to the one they have in root of main project - not checked tbh. That way at least when this theme needs to override module templates or include new templates in future Prestashop versions there is some consistency.

micka-fdz commented 4 years ago

I think we need to follow PS standards. According to the official documentation:

Use spaces for indentation in every language (PHP, HTML, CSS, etc.): 4 spaces for PHP files, 2 spaces for all other file types.