search

prestarocket-agence / classic-rocket

Classic Rocket is a rework of "classic theme". It has been built keeping in mind : performance, accessibility and SEO.
https://demoprestashop.prestarocket.com/
Other
229 stars 127 forks source link

breadcrumb.tpl - block name conflict #104

Closed damiweb closed 4 years ago

damiweb commented 5 years ago

The same name of block is used in layout (layoyt-both-columns.tpl). It is problematic in case we want to override layout breadcrumb block in descendant templates.

https://github.com/PrestaShop/classic-rocket/blob/3c799c4bd8d5fce7addf87a5d205e6791880b75f/templates/_partials/breadcrumb.tpl#L28

https://github.com/PrestaShop/classic-rocket/blob/3c799c4bd8d5fce7addf87a5d205e6791880b75f/templates/layouts/layout-both-columns.tpl#L57

My advice is to change the name of block in breadcrumb.tpl, because it is rarely overridden.

micka-fdz commented 5 years ago

Proposed PR : #108