search

prestarocket-agence / classic-rocket

Classic Rocket is a rework of "classic theme". It has been built keeping in mind : performance, accessibility and SEO.
https://demoprestashop.prestarocket.com/
Other
230 stars 127 forks source link

use category images for og:image on category page #144

Closed dosbiner closed 4 years ago

prestarocket commented 4 years ago

@micka-fdz what do you think about this PR ?

micka-fdz commented 4 years ago

I think we need to test if image exists before using it. But I don't know if category images are relevant here. @NeOMakinG what do you recommend?

NeOMakinG commented 4 years ago

@micka-fdz @prestarocket It depends of your own choice to be honest, if you prefer that every shops get their logo shown on social networks shares or the category image then close this PR, otherwise if you think that showing the category img is right, then do it! Anyway it needs to check is the category image exist, and if not, then showing the shop logo.