search

prestarocket-agence / classic-rocket

Classic Rocket is a rework of "classic theme". It has been built keeping in mind : performance, accessibility and SEO.
https://demoprestashop.prestarocket.com/
Other
230 stars 127 forks source link

Serious issues on Internet Explorer and Edge #162

Closed dangelion closed 4 years ago

dangelion commented 4 years ago

On IE 11 in console you get error:

SCRIPT1002 (it's a syntax error on bottom-xxxxx.js)

On Edge you get:

SCRIPT1028: Expected identifier, string or number

In both cases it blocks the JS execution and the website is broken.

You can check these errors on your demo online.

Lot of results and solutions googling it Maybe the fastest one would be adding Babel to translate the code to ES5 syntax (?)

Very serious issues, is it possible to solve them asap? Thanks

prestarocket commented 4 years ago

I figured it out, and I hate webpack.

dangelion commented 4 years ago

@prestarocket have you in plan to solve this soon? It's a huge problem for my client...

prestarocket commented 4 years ago

@dangelion i have to create a release but it s fix here : https://github.com/prestarocket-agence/classic-rocket/issues/162

matks commented 4 years ago

I figured it out, and I hate webpack.

You're not alone https://twitter.com/STuFFk/status/1270431858703073280?s=19