search

prestarocket-agence / classic-rocket

Classic Rocket is a rework of "classic theme". It has been built keeping in mind : performance, accessibility and SEO.
https://demoprestashop.prestarocket.com/
Other
230 stars 127 forks source link

Need feedback on New HP #196

Closed prestarocket closed 3 years ago

prestarocket commented 3 years ago

Home

francoispeyret commented 3 years ago

interesting, do you need help with integration?

prestarocket commented 3 years ago

thx @francoispeyret not yet, for the beta we ll need help

dosbiner commented 3 years ago

Maybe native lazy loading? Can save some bytes. https://caniuse.com/loading-lazy-attr

prestarocket commented 3 years ago

@dosbiner yes like this : https://gist.github.com/addyosmani/08da4286144679292f406b75fc4bfab4

mstfblci commented 3 years ago

I can help for the beta.

prestarocket commented 3 years ago

for any help for the beta, plz send me an email : adonis.karavokyros@prestarocket.com cc @madonetr @francoispeyret

Hlavtox commented 3 years ago

@prestarocket Looks amazing!!!

prestarocket commented 3 years ago

any feed back on this new HP ? We will create new modules :

any suggestions ?

mstfblci commented 3 years ago

any feed back on this new HP ? We will create new modules :

  • custom text with picture
  • banner text

any suggestions ?

We should be able to add more than one banner to the homepage. Look like this: https://i.hizliresim.com/Htb1s8.png

Hlavtox commented 3 years ago

@prestarocket

Menu https://user-images.githubusercontent.com/6097524/99664474-86b66d80-2a68-11eb-942a-56ec8a910b80.PNG Thumbnails https://user-images.githubusercontent.com/6097524/99664233-26bfc700-2a68-11eb-910f-f084a7fdce67.JPG Categories https://user-images.githubusercontent.com/6097524/99664546-a057b500-2a68-11eb-9fb8-f7c63e7835a5.JPG

kpodemski commented 3 years ago

I love the simplicity of it. The one thing I don't like tho is background od searchbar, I'd go for transparent bg or lighter grey.

dosbiner commented 3 years ago

Need to support JSON-LD for ps default productcomments: rating, review, aggregate rating, review count, reviewBody, author

chbj commented 3 years ago

I absolutely love the new UI. It looks super fresh compared to the old one. Do you have mockups available for other parts of the site? Product page, checkout etc.

When is it expected to be released?

prestarocket commented 3 years ago

@chbj https://github.com/prestarocket-agence/classic-rocket/issues/204 https://github.com/prestarocket-agence/classic-rocket/issues/205

chbj commented 3 years ago

@prestarocket Looks great. I really like the new My Account page, compared to the standard one.

Is Foot.fr running on a beta of the new Classic rocket? Or are they simply using the same cart design that it will feature?

prestarocket commented 3 years ago

@chbj this cart feature is from classic rocket beta

prestarocket commented 3 years ago

To do this properly (cart detail in offcanvas), the content should appear in ajax mode or generated in js on the fly (for performance reasons).

rookmoot commented 3 years ago

Hi aller! Juste saw you asking for feedback. Il guess the design is pretty neat and clean. Ideal for a base theme. Btw, my first impression was that it wasnt looking like an e-commerce theme but much more like a landing page. I think product miniature need to be updated to look more like products. It's only my thoughts :-) great job !

mstfblci commented 3 years ago

I want to help with the beta version but I still haven't gotten a feedback.

prestarocket commented 3 years ago

next week we will publish the beta

Le mer. 3 mars 2021 à 21:49, madonetr notifications@github.com a écrit :

I want to help with the beta version but I still haven't gotten a feedback.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/prestarocket-agence/classic-rocket/issues/196#issuecomment-790045028, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAG3SXTEL7VIG7PM3JU44DDTB2OFHANCNFSM4TEZIJHQ .

--

Dernières réalisations :

On parle de nous : https://blog.dareboost.com/fr/2019/04/refonte-theme-prestashop-performance/

[image: SARL JUST WEB - Prestarocket]

Adonis KARAVOKYROS Gérant

PRESTAROCKET | LILLE m: 06.68.69.01.20 w: prestarocket.com e: adonis.karavokyros@prestarocket.com kevin.francomme@prestarocket.com

0dp commented 3 years ago

I am gonna go out on a limb here and join the conversation with my two cents.

I am personally not looking for at theme that 'forces' a UI or UX on the developer, rather a bare-bone framework for developers; enabling more rapid development.

The reason why I came to classic-rocket was because of the light weight nature of the theme compared to the default theme. A lot of the clean up work and optimization was already done for me which gave me a head start. It was easy for me to modify the build tasks and add my own. I could easily bump package versions and get an overview of the consequences; getting me to a starting point that fits the scope of the assignment. Kudos!

Modules for visual elements, flyout carts, mega-menus, icons, material design etc. is all great if you need it for your project. But if you don't you have to make an effort to clean it up. Rather it should be optional if you want features like material icons included.

I might be misunderstanding since I am new in this conversation, but shouldn't adding features to the theme be avoided? Quite the opposite, shouldn't the focus for a new version be to create the most optimized lightweight version, giving the developers the tools to create the experience (ie. activate material icons, activate material design flyout cart, activate pretty my account pages)?

Here is some things that I would like to see:

I might come back and edit this comment later, but leaving it for now.

prestarocket commented 3 years ago

@0dp Thank you for your feedback. The v2 will be easier to modify; we tried to separate the scss files as much as possible by applying the BEMIT philosophy. Same for tpl: more tpl to include, more smarty block etc..

Here is an overview of the structure of the scss files and theme.js

Capture d’écran 2021-03-16 à 11 27 22 Capture d’écran 2021-03-16 à 11 27 00 Capture d’écran 2021-03-16 à 11 22 21

For conditional javascript module loading, i don t think it s possible without modify PS core files. We don t use anymore material icon but inline SVG : {include file="_partials/icon.tpl" icon="eye" class="c-icon--24"}

0dp commented 3 years ago

@prestarocket ok that's great! So something like svgstore could potentially be worth looking into.

Can I ask, why is the code for v2 not public and invite only, or am i missing something?

prestarocket commented 3 years ago

@0dp do you have a twitter account ?

0dp commented 3 years ago

Unfortunately not

prestarocket commented 3 years ago

adonis.karavokyros@prestarocket.com (drop me an email plz)

Benjaminpr commented 3 years ago

Hello ! I would like to try and contribute if possible to the new version of the theme, is there any way to get access to it ?

prestarocket commented 3 years ago

hello @Benjaminpr send me an email plz

0dp commented 3 years ago

@prestarocket why not make the repo public?

kennethbruyninckx commented 3 years ago

Where can we find the v2 / beta for testing?

diseneopl commented 3 years ago

@prestarocket We waiting impatiently for v2, we would like to create new themes on new version. When any beta / release date?

lightonmagazine commented 3 years ago

hi @prestarocket the V2 looks amazing. Do you have a public release date ?

prestarocket commented 3 years ago

Hello,

Beta is public : https://github.com/prestarocket-agence/classic-rocket/tree/release/4.0.0-beta.001 demo : https://crv2.prestarocket.com/