search

prestarocket-agence / classic-rocket

Classic Rocket is a rework of "classic theme". It has been built keeping in mind : performance, accessibility and SEO.
https://demoprestashop.prestarocket.com/
Other
229 stars 127 forks source link

jpg extension support is missing #212

Closed dali-rajab closed 3 years ago

dali-rajab commented 3 years ago

Hello ! I think we should modify this line, because it's not supporting jpg extensions, => jpe?g (optionnal e) :

npm_jpg

https://github.com/prestarocket-agence/classic-rocket/blob/4dad8fcbc30a25b3963ae5b9e3fb3790dac9a563/_dev/webpack.config.js#L103

to become : 

test: /\.(png|jpe?g|gif|svg|webp)$/,

I tested and it works

tswfi commented 3 years ago

Thanks!

There are no jpg or jpeg files in the theme but as this is also used as a base for child themes its probably good to fix this to show an example :)

Opened pr to fix this: https://github.com/prestarocket-agence/classic-rocket/pull/225