prestarocket-agence / classic-rocket

Classic Rocket is a rework of "classic theme". It has been built keeping in mind : performance, accessibility and SEO.
https://demoprestashop.prestarocket.com/
Other
229 stars 127 forks source link

use npm for slick.js #5

Closed duGuillaume closed 6 years ago

duGuillaume commented 6 years ago

hi,

i think it will be more easier to maintain if you used slick from npm instead load it from lib folder.

https://www.npmjs.com/package/slick-carousel

prestarocket commented 6 years ago

With the official npm pack., it s not the last version of slick.. (1.8.1 vs 1.9). maybe we could use this one: https://www.npmjs.com/package/slick-carousel-latest WDYT ?

duGuillaume commented 6 years ago

It's look great, but do you think this package will be maintain or it's just a temporary package until official release ?

duGuillaume commented 6 years ago

what do you think about add hoverintent too ?

https://www.npmjs.com/package/jquery-hoverintent

kpodemski commented 6 years ago

Slick is not updated that often, i don't think that you guys need to worry about it and put in as npm package :)

prestarocket commented 6 years ago

same for hoverIntent; thx @kpodemski