search

prestarocket-agence / classic-rocket

Classic Rocket is a rework of "classic theme". It has been built keeping in mind : performance, accessibility and SEO.
https://demoprestashop.prestarocket.com/
Other
229 stars 127 forks source link

Image not showing on Internet Explorer #77

Closed msaustral closed 4 years ago

msaustral commented 5 years ago

Hi after done all the update of Webpack and dependencies, on IE the image are not been shown, on the console got this error: image

image

image

This is my package.json:

{ "name": "australpygb", "version": "1.0.0", "description": "Tema de Austral", "main": "index.js", "scripts": { "build": "webpack --mode production --progress --colors --debug --display-chunks", "watch": "webpack --mode development --progress --colors --debug --display-chunks --watch" }, "author": "Ausral", "license": "AFL-3.0", "devDependencies": { "@babel/core": "^7.5.4", "ajv": "^6.9.1", "autoprefixer": "^9.4.4", "babel-loader": "^8.0.6", "bootstrap": "4.3.1", "bootstrap-touchspin": "^4.2.5", "css-loader": "^3.0.0", "expose-loader": "^0.7.3", "file-loader": "^4.0.0", "flexibility": "^1.0.5", "gulp": "^4.0.0", "gulp-autoprefixer": "^6.0.0", "gulp-replace": "^1.0.0", "gulp-sass": "^4.0.2", "gulp-sourcemaps": "^2.6.5", "jquery": "^3.4.1", "lazysizes": "4.1.5", "material-design-icons": "^2.1.3", "mini-css-extract-plugin": "^0.7.0", "node-sass": "^4.5.0", "popper.js": "^1.14.3", "postcss-flexibility": "^2.0.0", "postcss-loader": "^3.0.0", "sass-loader": "^7.1.0", "style-loader": "^0.14.0", "terser-webpack-plugin": "^1.3.0", "webpack": "^4.35.3", "webpack-cli": "^3.3.5", "webpack-dev-server": "^3.7.2", "webpack-sources": "^0.1.0" }, "dependencies": { "babel-preset-react": "^6.24.1" } }

PrestaShop version 1.7.6

I did try on fresh installation and install the theme and it works, no idea what is not working!

prestarocket commented 5 years ago

I am still working on the update, the theme is not fully compatible 1.7.6

msaustral commented 5 years ago

Hi I don't think it is a problem with Prestashop 1.7.6, if I download the theme and install it as it is on Github on 1.7.6 it works fine.

I think must be a problem with Jquery or any other dependency that I did update on the webpack by NPM.

It works fine on all browsers less IE, I have no idea where to start to find the issue!

dangelion commented 4 years ago

@prestarocket @msaustral Same problem here. Any updates?

prestarocket commented 4 years ago

@dangelion @msaustral could you give an url to check plz ?

dangelion commented 4 years ago

@prestarocket you can check your demo online: https://demoprestashop.prestarocket.com/fr/ using Microsoft Edge

In console you get SCRIPT1028: Expected identifier, string or number error (same as the screenshot posted by @msaustral). So you have no images and JS execution blocked. The result is our websites are broken

Lot of results and solutions googling it Maybe the fastest one would be adding Babel to translate the code to ES5 syntax (?)