[Improvement] Passive event listener

prestarocket-agence / classic-rocket

Classic Rocket is a rework of "classic theme". It has been built keeping in mind : performance, accessibility and SEO.

https://demoprestashop.prestarocket.com/

Other

230 stars 127 forks source link

[Improvement] Passive event listener #82

Closed dosbiner closed 5 years ago

dosbiner commented 5 years ago

fix warning reported by Google Chrome Dev tool: Audits source:

prestarocket commented 5 years ago

could you make a PR on develop branch ?

MockoB commented 5 years ago

Hi @prestarocket, I saw you closed the issue, but are the passive event listeners added to the theme? Because it is a must have addition I believe. Thanks

prestarocket commented 5 years ago

i need more info and you can send a PR; which part of code is responsible for these warnings ?

MockoB commented 5 years ago

Unfortunately I'm not developer @prestarocket, and I can't make a PR. But here is a screenshot of google lighthouse recommendation: https://ibb.co/Lz7HGrt you could easily check what needs to be changed in the template by yourself.

And here is interesting article, where you could find more info concerning the topic: https://github.com/WICG/EventListenerOptions/blob/gh-pages/explainer.md

prestarocket commented 5 years ago

it's cause by third party plugins like slick slider