If you click two or more times add to cart button, crazy

prestarocket-agence / classic-rocket

Classic Rocket is a rework of "classic theme". It has been built keeping in mind : performance, accessibility and SEO.

https://demoprestashop.prestarocket.com/

Other

229 stars 127 forks source link

If you click two or more times add to cart button, crazy #85

Closed acentoweb closed 5 years ago

acentoweb commented 5 years ago

reproduction:

If you remove

&&n.remove()

from theme.js the problem is solved

prestarocket commented 5 years ago

could you try here : https://demoprestashop.prestarocket.com/art/3-13-affiche-encadree-the-best-is-yet-to-come.html#/19-dimension-40x60cm

acentoweb commented 5 years ago

Thanks @prestarocket . Same results

acentoweb commented 5 years ago

Perhaps, a good idea would be:

if you click button: attr disabled
When you close blockcart or click continue, enabled ?¿ Thanks

prestarocket commented 5 years ago

it s not linked to the theme, same pb with classic theme : http://demo.prestashop.com

kpodemski commented 5 years ago

but you can fix it by making add to cart button disabled after first click, and enabling it after updatedCart

prestarocket commented 5 years ago

done

matks commented 5 years ago

it s not linked to the theme, same pb with classic theme : http://demo.prestashop.com

Hi @prestarocket I'm sorry but I fail to reproduce the behavior 🤔 can you please tell me exactly what I must do to see the bug and what is expected ?

Right now on http://demo.prestashop.com/#/en/front:

if I click ton 'add to cart' the modal opens
if I click on 'continue shopping' the modal disappears
if I click on 'add to cart' while the modal is opened, the modal disappears too

I tried a very quick double-click too, I got nothing that looks weird

prestarocket commented 5 years ago

it s not linked to the theme, same pb with classic theme : http://demo.prestashop.com

Hi @prestarocket I'm sorry but I fail to reproduce the behavior 🤔 can you please tell me exactly what I must do to see the bug and what is expected ?

Right now on http://demo.prestashop.com/#/en/front:

if I click ton 'add to cart' the modal opens

if I click on 'continue shopping' the modal disappears

if I click on 'add to cart' while the modal is opened, the modal disappears too

I tried a very quick double-click too, I got nothing that looks weird

click like a crazy man before modal opens :)

matks commented 5 years ago

it s not linked to the theme, same pb with classic theme : http://demo.prestashop.com

Hi @prestarocket I'm sorry but I fail to reproduce the behavior 🤔 can you please tell me exactly what I must do to see the bug and what is expected ? Right now on http://demo.prestashop.com/#/en/front:

if I click ton 'add to cart' the modal opens

if I click on 'continue shopping' the modal disappears

if I click on 'add to cart' while the modal is opened, the modal disappears too

I tried a very quick double-click too, I got nothing that looks weird

click like a crazy man before modal opens :)

OK like reaaaaaaal crazy then 😄 I got it

matks commented 5 years ago

I submitted the bug https://github.com/PrestaShop/PrestaShop/issues/15483 for classic theme 😉

uruk-hai-21 commented 5 years ago

a solution could be to add to css style:

.add-to-cart.is--loading { pointer-events: none !important; cursor: none !important; }