prestja / Kopernicus

Kopernicus is a mod for Kerbal Space Program which allows users to replace the planetary system used by the game.
GNU Lesser General Public License v3.0
17 stars 6 forks source link

Incorrect ScaledSpace atmospheric glow for multi-star systems #30

Closed prestja closed 3 years ago

prestja commented 3 years ago

https://forum.kerbalspaceprogram.com/index.php?/topic/194936-191-kopernicus-continued/&do=findComment&comment=3831455

https://forum.kerbalspaceprogram.com/index.php?/topic/194936-191-kopernicus-continued/&do=findComment&comment=3831479

democat3457 commented 3 years ago

reee rimColorRamp is merely exposing the option "_rimColorRamp" in the builtin shaders "Terrain/Scaled Planet (RimAerial)" or "Terrain/Scaled Planet (RimAerial) Standard"

OhioBob commented 3 years ago

Further testing of this issue has uncovered that if the body uses an Eeloo template, the rim glow points to the correct star. Of course one shouldn't be forced to use an Eeloo template, it should work with any template. But perhaps Eeloo contains the solution to the problem.

R-T-B commented 3 years ago

I'm working on this in bleeding edge now. I too think Eeloo is the key.

R-T-B commented 3 years ago

This is fixed on bleeding edge, awaiting testing for merge to stable.

R-T-B commented 3 years ago

Marking this as fixed, as it is in latest release.