search

prestja / Kopernicus

Kopernicus is a mod for Kerbal Space Program which allows users to replace the planetary system used by the game.
GNU Lesser General Public License v3.0
17 stars 6 forks source link

Broken lighting on gas gaints #33

Closed ra4nd0m closed 4 years ago

ra4nd0m commented 4 years ago

Lighting broken both in science archive and in game. image image image Clean install Kop 191.1-RC_HF3 image Player.log

ra4nd0m commented 4 years ago

Maybe somehow connected to that Jool shader disabler code that caused this bug in 1.10? Or these are separate branches?

democat3457 commented 4 years ago

iirc the normal map needs to be at 50% opacity to rotate in the correct direction (towards the local star)?

R-T-B commented 4 years ago

Yeah, I know what causes this. It was my attempt to fix this bug by using builtin cloudmaps:

https://github.com/R-T-B/Kopernicus/issues/18

The builtin cloudmaps seem bugged though. So either we use a desaturated, pale normal map and get correct shadows, or we don't and we get this.

Any ideas? I'll consult an artist friend of mine to see if he can make our included generic normal map not desaturate so bad. If so, the fix is easy and simple and not a show stopper.

R-T-B commented 4 years ago

I fixed it, release pending. We just had to use a generic flat normal map (can be made easily as I just did), not the thing we had before that I grabbed randomly from some example and just assumed worked.

The apperance may differ slightly from former releases but it is more than acceptable, and lighting works.

R-T-B commented 4 years ago

Got this bug fixed in hotfix 4. Due to the simplicity of the fix, I do not consider this a blocker to CKAN.