search

prestodb / airlift

Airlift framework for building REST services
Apache License 2.0
1 stars 42 forks source link

Revert SSL changes #50

Closed ajaygeorge closed 2 years ago

ajaygeorge commented 2 years ago

Revert SSL commits which are causing issues.

ajaygeorge commented 2 years ago

@ShashwatArghode / @aweisberg
We are reverting a few commits related to SSL due to issues we saw in deploying this version in Prod.

Some of the errors we saw :

java.io.UncheckedIOException: javax.net.ssl.SSLException: Received fatal alert: bad_record_mac
        at com.facebook.airlift.http.client.ResponseHandlerUtils.propagate(ResponseHandlerUtils.java:21)
        at com.facebook.airlift.http.client.FullJsonResponseHandler.handleException(FullJsonResponseHandler.java:58)
        at com.facebook.presto.server.smile.AdaptingJsonResponseHandler.handleException(AdaptingJsonResponseHandler.java:50)
        at com.facebook.presto.server.smile.AdaptingJsonResponseHandler.handleException(AdaptingJsonResponseHandler.java:31)
        at com.facebook.airlift.http.client.jetty.JettyResponseFuture.failed(JettyResponseFuture.java:122)
        at com.facebook.airlift.http.client.jetty.BufferingResponseListener.onComplete(BufferingResponseListener.java:85)
java.io.UncheckedIOException: javax.net.ssl.SSLException: Fail to wrap application data
        at com.facebook.airlift.http.client.ResponseHandlerUtils.propagate(ResponseHandlerUtils.java:21)
        at com.facebook.airlift.http.client.FullJsonResponseHandler.handleException(FullJsonResponseHandler.java:58)
        at com.facebook.presto.server.smile.AdaptingJsonResponseHandler.handleException(AdaptingJsonResponseHandler.java:50)
        at com.facebook.presto.server.smile.AdaptingJsonResponseHandler.handleException(AdaptingJsonResponseHandler.java:31)
        at com.facebook.airlift.http.client.jetty.JettyResponseFuture.failed(JettyResponseFuture.java:122)
        at com.facebook.airlift.http.client.jetty.BufferingResponseListener.onComplete(BufferingResponseListener.java:85)
        at org.eclipse.jetty.client.ResponseNotifier.notifyComplete(ResponseNotifier.java:218)
        at org.eclipse.jetty.client.ResponseNotifier.notifyComplete(ResponseNotifier.java:210)
        at org.eclipse.jetty.client.HttpSender.terminateRequest(HttpSender.java:411)
        at org.eclipse.jetty.client.HttpSender.abort(HttpSender.java:574)
        at org.eclipse.jetty.client.HttpSender.lambda$executeAbort$0(HttpSender.java:361)
        at org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:882)
        at org.eclipse.jetty.util.thread.QueuedThreadPool$Runner.run(QueuedThreadPool.java:1036)
        at java.base/java.lang.Thread.run(Thread.java:834)
Caused by: javax.net.ssl.SSLException: Fail to wrap application data
        at java.base/sun.security.ssl.Alert.createSSLException(Alert.java:133)
        at java.base/sun.security.ssl.TransportContext.fatal(TransportContext.java:349)
java.lang.IllegalStateException: Unexpected unwrap result BUFFER_OVERFLOW
        at org.eclipse.jetty.io.ssl.SslConnection$DecryptedEndPoint.fill(SslConnection.java:790)
        at org.eclipse.jetty.client.http.HttpReceiverOverHTTP.process(HttpReceiverOverHTTP.java:164)
        at org.eclipse.jetty.client.http.HttpReceiverOverHTTP.receive(HttpReceiverOverHTTP.java:79)
        at org.eclipse.jetty.client.http.HttpChannelOverHTTP.receive(HttpChannelOverHTTP.java:131)
        at org.eclipse.jetty.client.http.HttpConnectionOverHTTP.onFillable(HttpConnectionOverHTTP.java:172)
        at org.eclipse.jetty.io.AbstractConnection$ReadCallback.succeeded(AbstractConnection.java:311)
        at org.eclipse.jetty.io.FillInterest.fillable(FillInterest.java:105)
        at org.eclipse.jetty.io.ssl.SslConnection$DecryptedEndPoint.onFillable(SslConnection.java:555)