prestodb / presto-maven-plugin

Maven packaging and lifecycle for Presto plugins
Apache License 2.0
6 stars 26 forks source link

Add Windows path separator support. #7

Open songdongsheng opened 6 years ago

songdongsheng commented 6 years ago

With this patch, Presto plugin can be packaged on Windows.

Hollyen commented 5 years ago

i have run into the problem when compiling presto, see https://github.com/prestodb/presto/issues/11818

I think this PR will solve the problem, anyone can merge this??

carlosfvp commented 3 years ago

Can anyone merge this?

dnskr commented 1 year ago

The PR allows to build Presto on Windows because it fixes the following issue:

[INFO] --- presto-maven-plugin:0.4:generate-service-descriptor (default-generate-service-descriptor) @ presto-tpch ---
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  5.863 s
[INFO] Finished at: 2023-01-18T00:33:33+01:00
[INFO] ------------------------------------------------------------------------