The function get_logger is never really utilised, its level argument is never used. Let's use logging.getLogger(__name__) directly instead? It should be up to the binary and not the library to be setting the logging level.
If we fear that someone might be using prestodb.logging, we could simply remove the setLevel, though personally I don't think anything would be, if they are, it's a quick fix. We could opt to version bump to 0.9.0 as well.
The function
get_logger
is never really utilised, itslevel
argument is never used. Let's uselogging.getLogger(__name__)
directly instead? It should be up to the binary and not the library to be setting the logging level.If we fear that someone might be using
prestodb.logging
, we could simply remove thesetLevel
, though personally I don't think anything would be, if they are, it's a quick fix. We could opt to version bump to0.9.0
as well.