prestodb / presto-python-client

Python DB-API client for Presto
Apache License 2.0
239 stars 87 forks source link

Remove logging module and use logging.getLogger directly. #118

Closed AndreasBackx closed 2 years ago

AndreasBackx commented 2 years ago

The function get_logger is never really utilised, its level argument is never used. Let's use logging.getLogger(__name__) directly instead? It should be up to the binary and not the library to be setting the logging level.

If we fear that someone might be using prestodb.logging, we could simply remove the setLevel, though personally I don't think anything would be, if they are, it's a quick fix. We could opt to version bump to 0.9.0 as well.

linux-foundation-easycla[bot] commented 2 years ago

CLA Signed

The committers listed above are authorized under a signed CLA.

arunthirupathi commented 2 years ago

Thanks for contributing this change.