Support decimal and time data types

prestodb / presto-python-client

Python DB-API client for Presto

Apache License 2.0

239 stars 87 forks source link

Support decimal and time data types #133

Open m1n0 opened 1 year ago

m1n0 commented 1 year ago

This is roughly a copy of what Trino did here https://github.com/trinodb/trino-python-client/pull/160 - with two exceptions:

no tests - I dont see dbapi tests in general in this repo
I added the experimental boolean flag to the connection itself, that seems to make more sense to me rather than adding it to the cursor.

linux-foundation-easycla[bot] commented 1 year ago

The committers listed above are authorized under a signed CLA.

:white_check_mark: login: m1n0 / name: Milan Lukac (90944f0860e0c5a32cea5a38b1f8f31e76c6fe08)

m1n0 commented 1 year ago

is there something blocking this @tdcmeehan ?

tdcmeehan commented 11 months ago

@m1n0 can you please ask for help in the PrestoDB Slack to get this PR moving? I am not a Python expert, but I can help provide a surface review later.

m1n0 commented 11 months ago

thanks for the comment @tdcmeehan ! I already did that when I opened the PR, I just asked again now.

wanglinsong commented 11 months ago

I can deploy a cluster in AWS and let you try this out.

m1n0 commented 6 months ago

hi, what can I do to move this forward?

wanglinsong commented 6 months ago

hi, what can I do to move this forward?

Please run some BAT tests to make sure the new updates work. You can deploy a local cluster, or I can provide one.