search

prestodb / presto-python-client

Python DB-API client for Presto
Apache License 2.0
239 stars 87 forks source link

unpin requirements #53

Closed rgbkrk closed 6 years ago

rgbkrk commented 6 years ago

I'd like to propose not strictly pinning dependencies in this package, allowing users of this library to have their own pinned versions instead. If accepted and released, fantastic! If rejected, I'll make a fork (for now) that allows us to relax the dependencies.

ggreg commented 6 years ago

Maybe we could use an environment variable to make it flexible.

ggreg commented 6 years ago

Is the problem conflicting versions when using presto-python-client in a project with overlapping dependencies?

rgbkrk commented 6 years ago

That is correct. In fact, I want to use this in notebook environments where a large software stack is installed.

tnesztler commented 6 years ago

Any update on this? requests and six packages are currently clashing with other libraries causing dependencies resolution errors when using pipenv for example.

ggreg commented 6 years ago

Accepting this pull-request to unblock integration with other libraries

ggreg commented 6 years ago

Thanks for the pull request and raising this issue!