TupleDomainFilters are used to push range filters into TableScans. There is special code in Prestissimo Plan Fragment conversion to Velox to convert these filters. This logic is complex and involves interpretation of the value buffers from Presto, conversions needed for initializing filters (dependent on the conditionals) and also merging of range boundaries if applicable.
It would be better to have unit tests for this functionality based on the complexity. However, there is none right now.
aditi-pandit
commented
1 year ago
TupleDomainFilters are used to push range filters into TableScans. There is special code in Prestissimo Plan Fragment conversion to Velox to convert these filters. This logic is complex and involves interpretation of the value buffers from Presto, conversions needed for initializing filters (dependent on the conditionals) and also merging of range boundaries if applicable.
It would be better to have unit tests for this functionality based on the complexity. However, there is none right now.
Please add unit tests in https://github.com/prestodb/presto/blob/master/presto-native-execution/presto_cpp/main/types/tests/PlanConverterTest.cpp or a new unit test file.