search

prestodb / presto

The official home of the Presto distributed SQL query engine for big data
http://prestodb.io
Apache License 2.0
15.74k stars 5.28k forks source link

[Native] Implement hamming_distance() #20531

Open ethanyzhang opened 10 months ago

ethanyzhang commented 10 months ago

https://github.ibm.com/lakehouse/velox/pull/21 External: https://github.com/facebookincubator/velox/pull/6120

amitkdutta commented 10 months ago

@yzhang1991 This PR looks like inside a velox fork inside IBM. Are we planning to put it in https://github.com/facebookincubator/velox? CC: @aditi-pandit @mbasmanova

aditi-pandit commented 10 months ago

@amitkdutta : Yes, this PR will be moved to the public repo. I think Arun wanted to get some internal feedback before opening in the public repo.

wills-feng commented 3 months ago

I'm taking over this one, new PR is https://github.com/facebookincubator/velox/pull/9269

wills-feng commented 3 months ago

PR got merged.

aditi-pandit commented 3 months ago

@wills-feng : Please add Prestissimo e2e tests for this function. You can add a test in https://github.com/prestodb/presto/blob/master/presto-native-execution/src/test/java/com/facebook/presto/nativeworker/AbstractTestNativeGeneralQueries.java

wills-feng commented 3 months ago

@aditi-pandit thank you! Will follow up.