search

prestodb / presto

The official home of the Presto distributed SQL query engine for big data
http://prestodb.io
Apache License 2.0
16.06k stars 5.38k forks source link

Document types of $file_size and $file_modified_time #22627

Closed elharo closed 6 months ago

elharo commented 6 months ago

On https://prestodb.io/docs/current/connector/hive.html I see

The Hive connector exposes extra hidden metadata columns in Hive tables. You can query these columns as a part of SQL query like any other columns of the table.

$path : Filepath for the given row data $file_size : Filesize for the given row $file_modified_time : Last file modified time for the given row

However this fails to say whether these are int32s or int64s. Add that detail. I'm pretty sure the correct answer is int64.

steveburnett commented 6 months ago

@agrawalreetika, I believe this was originally your contribution.

Can you confirm if $file_size and $file_modified_time are int32s or int64s? I can update the doc once I know. Thanks!

aditi-pandit commented 6 months ago

@steveburnett : $file_size and $file_modified_time are int64_t for Presto Native Engine. I recently added these in Velox.

ref https://github.com/facebookincubator/velox/pull/8800 https://github.com/prestodb/presto/pull/21965

This would be compatible with Presto java. Though please confirm with Reetika as well.

agrawalreetika commented 6 months ago

@steveburnett : $file_size and $file_modified_time are int64_t for Presto Java as well.

steveburnett commented 6 months ago

Thanks @aditi-pandit and @agrawalreetika! I will open a doc PR to update the page.