Open elharo opened 4 months ago
These untracked files are from the #22645 (but they were not added by the PR, the PR removed them from the sources):
presto-main/src/main/resources/webapp/dev/query_viewer.js
presto-main/src/main/resources/webapp/dist/
@ZacBlanco also informed me about this issue The possible solutions are:
presto-main/target
directoryFor solution 2, it may need to tweak the webpack config to cover the dev scenarios. Need to make sure yarn watch
, yarn serve
work with the new JS location.
mvn clean
will delete it.@elharo
We need to put generated code somewhere mvn clean will delete it
That's option 2.
had to look in the maven-compiler-plugin source code but it likely belongs in
${project.build.directory}/generated-sources/
FYI, Presto is following the Maven stadnard directory layout: https://maven.apache.org/guides/introduction/introduction-to-the-standard-directory-layout.html
Yes, and nothing in that layout is for generated code.
for .js
files, they are equal to .class
which would go to target/classes
I've noticed that recently these new files keep showing up in my repo:
Untracked files: (use "git add..." to include in what will be committed)
presto-main/src/main/resources/webapp/dev/query_viewer.js
presto-main/src/main/resources/webapp/dist/
I think these belong instead in the generated-sources directory (or something like that; still need to fully debug and research this). I suspect they've been added as a result of #22645