Arrow-flight connector - Githubissues

prestodb / presto

The official home of the Presto distributed SQL query engine for big data

http://prestodb.io

Apache License 2.0

15.97k stars 5.35k forks source link

Arrow-flight connector #23032

Open sabbasani opened 3 months ago

sabbasani commented 3 months ago

Description

Motivation and Context

Impact

Test Plan

Contributor checklist

[ ] Please make sure your submission complies with our development, formatting, commit message, and attribution guidelines.
[ ] PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
[ ] Documented new properties (with its default value), SQL syntax, functions, or other functionality.
[ ] If release notes are required, they follow the release notes guidelines.
[ ] Adequate tests were added if applicable.
[ ] CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== RELEASE NOTES ==

General Changes
* Add Arrow Flight connector :pr:`23032`
* Add documentation for the :doc:`/connector/base-arrow-flight`  :pr:`23032`

If release note is NOT required, use:

== NO RELEASE NOTE ==

steveburnett commented 3 months ago

Consider adding documentation for the new connector.

Suggest revising the release note entry to follow the Release Note Guidelines:

== RELEASE NOTES ==

General Changes
* Add Arrow Flight connector :pr:`23032`

steveburnett commented 2 months ago

Suggest change to the release note entry as follows:

== RELEASE NOTES ==

General Changes
* Add Arrow Flight connector :pr:`23032`

The documentation for Arrow Flight Connector appears to be being added in #23212 , so it doesn't need to be mentioned in this release note.

linux-foundation-easycla[bot] commented 2 months ago

The committers listed above are authorized under a signed CLA.

:white_check_mark: login: SthuthiGhosh9400 (b3b34593ba5e2d4f0ab3942b0b5115bb97a5a844, 6c56ab9ecedb17a5fc06301b69966bb529faab4d, 1bbf2018eb53b565c34e28f121f4b40981a1a6e3, 6050c18af42f64a632c5034ab6ff8b09187f7887)
:white_check_mark: login: sabbasani (e824379cbdf837528518d26e8acb149594a81a2f)

sabbasani commented 2 months ago

@tdcmeehan @BryanCutler @steveburnett we have addressed all comments above.Can you please review

steveburnett commented 2 months ago

Suggest update of the release note to include the PR number in both entries, and to link to the new doc from the release note.

== RELEASE NOTES ==

General Changes
* Add Arrow Flight connector :pr:`23032`
* Add documentation for the :doc:`/connector/base-arrow-flight`  :pr:`23032`

tdcmeehan commented 1 month ago

@sabbasani is this PR still being worked on?

sabbasani commented 1 month ago

@sabbasani is this PR still being worked on?

@sabbasani is this PR still being worked on?

Yes @tdcmeehan I am working on testcases as discussed earlier

sabbasani commented 4 weeks ago

@tdcmeehan I have added testcases for arrow flight connector. Can you please review.