Open jackychen718 opened 3 months ago
Can you add unit tests? Also there must be a feature flag controlling this since I am not sure if this optimization will be always effective. What happens in count(*) case?
Can you add unit tests? Also there must be a feature flag controlling this since I am not sure if this optimization will be always effective. What happens in count(*) case?
I will add unit tests. Currently, I did not consider count(*) as a special way. From your reminding, I do not think I can still add filter before aggregation in this scenario. I will exclude this scenario in the pattern match process. Is it ok? @jaystarshot
@jackychen718 are you still working on this PR?
@tdcmeehan I keep in mind this task is not done yet. After I merge other PRs, I will come back to this one.
Description
Filter rows with all fileds null before aggregation.
Motivation and Context
The issue comes from #17486 Add optimiztion to drop groups/rows with all fields null
Impact
Add another opitimization rule: RemoveNullRowInAggregation.java
Test Plan
Test if any error made after applying the new optimization rule.
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.
== NO RELEASE NOTE ==