prestodb / presto

The official home of the Presto distributed SQL query engine for big data
http://prestodb.io
Apache License 2.0
15.74k stars 5.28k forks source link

Resolves: #22227 #23065

Open PUSHKAR99055 opened 6 days ago

PUSHKAR99055 commented 6 days ago

Description

I have modified the getColumnType method in the ResultSetMetadata class to ensure that the type names returned are in lowercase. This change addresses the inconsistency between the system.jdbc.types table, which stores type names in lowercase, and the ResultSetMetadata.getColumnTypeName method, which previously returned type names in uppercase.

Motivation and Context

This change is required to fix the capitalization inconsistency between the `DatabaseMetadata.getTypeInfo` method and the `ResultSetMetadata.getColumnTypeName` method. By ensuring consistent lowercase type names, we avoid potential issues and improve data consistency. This fixes issue #22227.

https://github.com/prestodb/presto/issues/22227

Impact

This change does not introduce any new public API or user-facing features. It ensures internal consistency of type names in the system. There is no significant performance impact expected from this change.

Test Plan

Contributor checklist

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== RELEASE NOTES ==

General Changes
Fixed capitalization issue in `ResultSetMetadata.getColumnType` to return type names in lowercase, ensuring consistency with `system.jdbc.types` table. :pr:`12345`

== NO RELEASE NOTE ==

linux-foundation-easycla[bot] commented 6 days ago

CLA Signed


The committers listed above are authorized under a signed CLA.

steveburnett commented 6 days ago

Suggest nit in release note entry, adding this PR number to it

== RELEASE NOTES ==

General Changes
Fix capitalization issue in `ResultSetMetadata.getColumnType` to return type names in lowercase, ensuring consistency with `system.jdbc.types` table. :pr:`23065`