Delete TaskExecutorSimulator.java

prestodb / presto

The official home of the Presto distributed SQL query engine for big data

http://prestodb.io

Apache License 2.0

15.96k stars 5.35k forks source link

Delete TaskExecutorSimulator.java #23075

Closed elharo closed 5 days ago

elharo commented 3 months ago

Description

Delete TaskExecutorSimulator.java

Motivation and Context

No longer used

Impact

None

Test Plan

Contributor checklist

[x] Please make sure your submission complies with our development, formatting, commit message, and attribution guidelines.
[x] PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
[ ] Documented new properties (with its default value), SQL syntax, functions, or other functionality.
[ ] If release notes are required, they follow the release notes guidelines.
[ ] Adequate tests were added if applicable.
[ ] CI passed.

Release Notes

== NO RELEASE NOTE ==

elharo commented 3 months ago

singlestore is failing again

tdcmeehan commented 3 months ago

I think there's other things in this directory that can also be deleted, should we remove them as well?

elharo commented 3 months ago

Yes, we should. It's a little easier and safer to take them out one at a time (unless you think the whole directory can go, in which case I can delete that in a single PR)

elharo commented 2 months ago

Can we go ahead and merge this one?

tdcmeehan commented 2 months ago

I believe the whole directory can be deleted--can you check that it can be deleted cleanly (i.e. there are no external references to the files in this directory)? I'd rather delete all or nothing.

elharo commented 2 months ago

Easier to do it one piece at a time. Right now this is ready to remove. No idea when I'll have time to do the rest of it.

elharo commented 6 days ago

Doesn't look like the entire directory can be deleted. There's at least one test class in there; i.e. contains TestNG tests, not just test utilities and mocks.

elharo commented 5 days ago

superseded