Exclude presto-ui from shaded jar

elharo commented 3 months ago

Description

Keeps the ui out of the test jar

Motivation and Context

Avoids duplicate finder errors.

Impact

None

Test Plan

mvn -pl presto-jdbc  install -DskipTests -T1C
jar tvf /Users/elharo/.m2/repository/com/facebook/presto/presto-jdbc/0.289-SNAPSHOT/presto-jdbc-0.289-SNAPSHOT.jar| grep webapp

Contributor checklist

[x] Please make sure your submission complies with our development, formatting, commit message, and attribution guidelines.
[x] PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
[ ] Documented new properties (with its default value), SQL syntax, functions, or other functionality.
[ ] If release notes are required, they follow the release notes guidelines.
[ ] Adequate tests were added if applicable.
[ ] CI passed.

Release Notes

== NO RELEASE NOTE ==

elharo commented 3 months ago

more singlestore flakeage

ZacBlanco commented 3 months ago

Actually, wondering if we still need the exclusion in the presto-main dependency with this filter now?

elharo commented 3 months ago

I suspect we do, but you can always take it out and see what happens.

ZacBlanco commented 3 months ago

I had tested locally removing the exclusion and it had no effect on the existence of the webapp/ folder in the shaded jar (with and without this PR applied). I think it is not necessary?

elharo commented 3 months ago

I was thinking the exclusion might be there for reasons other than shading in presto-jdbc.

prestodb / presto