prestodb / presto

The official home of the Presto distributed SQL query engine for big data
http://prestodb.io
Apache License 2.0
15.96k stars 5.35k forks source link

Upgrade presto-maven-plugin to 0.5 #23096

Open dnskr opened 3 months ago

dnskr commented 3 months ago

Description

Upgrade presto-maven-plugin to the latest 0.5 version.

Motivation and Context

Release presto-maven-plugin:0.5 has fix https://github.com/prestodb/presto-maven-plugin/pull/11 that resolves https://github.com/prestodb/presto-maven-plugin/issues/1 issue. The fix allows to build (at least) presto-tpch, presto-password-authenticators, presto-session-property-managers, presto-node-ttl-fetchers and presto-cluster-ttl-providers modules on Windows.

Impact

Developers can build more Presto modules on Windows.

Test Plan

Tested manually with the following commands:

mvn -f presto-tpch/pom.xml clean install -DskipTests=true
mvn -f presto-password-authenticators/pom.xml clean install -DskipTests=true
mvn -f presto-session-property-managers/pom.xml clean install -DskipTests=true
mvn -f presto-node-ttl-fetchers/pom.xml clean install -DskipTests=true
mvn -f presto-cluster-ttl-providers/pom.xml clean install -DskipTests=true

For instance, build result for presto-tpch before the upgrade:

$ mvn -f presto-tpch/pom.xml clean install -DskipTests=true
[INFO] Scanning for projects...
[INFO] 
[INFO] Using the MultiThreadedBuilder implementation with a thread count of 12
[INFO] 
[INFO] ------------------< com.facebook.presto:presto-tpch >-------------------
[INFO] Building presto-tpch 0.289-SNAPSHOT
...
[INFO] --- presto:0.4:generate-service-descriptor (default-generate-service-descriptor) @ presto-tpch ---
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  6.519 s (Wall Clock)
[INFO] Finished at: 2024-06-26T23:42:49+02:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal com.facebook.presto:presto-maven-plugin:0.4:generate-service-descriptor (default-generate-service-descriptor) on project presto-tpch: Execution default-generate-service-descriptor of goal com.facebook.presto:prest
o-maven-plugin:0.4:generate-service-descriptor failed: A required class was missing while executing com.facebook.presto:presto-maven-plugin:0.4:generate-service-descriptor: com/facebook/presto/tpch/ColumnNaming (wrong name: com\facebook\presto\tpch\ColumnNaming)

Build result for presto-tpch after the upgrade:

$ mvn -f presto-tpch/pom.xml clean install -DskipTests=true
[INFO] Scanning for projects...
[INFO] 
[INFO] Using the MultiThreadedBuilder implementation with a thread count of 12
[INFO] 
[INFO] ------------------< com.facebook.presto:presto-tpch >-------------------
[INFO] Building presto-tpch 0.289-SNAPSHOT
...
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  10.322 s (Wall Clock)
[INFO] Finished at: 2024-06-26T23:42:19+02:00
[INFO] ------------------------------------------------------------------------

Contributor checklist

Release Notes

== NO RELEASE NOTE ==
tdcmeehan commented 2 months ago

It looks like the release isn't in central. Do you know if it was published?

dnskr commented 2 months ago

It looks like the release isn't in central. Do you know if it was published?

It was not published due to credential issue and looks like the issue is not resolved yet.