prestodb / presto

The official home of the Presto distributed SQL query engine for big data
http://prestodb.io
Apache License 2.0
15.74k stars 5.28k forks source link

[native] Reduce numer of http requests for Exchange #23097

Closed arhimondr closed 3 days ago

arhimondr commented 3 days ago

Description

Reduce number of HTTP requests issued by exchange protocol

Motivation and Context

With high number of partitions the amount of data exchanged in a single round trip can be quite low (~50kb). This PR reduces number of explicit acknowledge calls as well as increases the long pool delay to avoid sending unnecessary pings when the buffers are empty (for example of not yet active stages).

Impact

Improves cpu efficiency at a fully utilized cluster by ~5%.

Test Plan

CI

Contributor checklist

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== NO RELEASE NOTE ==
arhimondr commented 3 days ago

Related changes in Velox:

majetideepak commented 3 days ago

Let's try to advance Velox in a separate PR when possible.

majetideepak commented 3 days ago

My bad! I just noticed it is in a separate commit. This works!