search

prestodb / presto

The official home of the Presto distributed SQL query engine for big data
http://prestodb.io
Apache License 2.0
16.06k stars 5.38k forks source link

[native] TestPrestoNativeIcebergTpcdsQueriesParquetUsingThrift.doDeletesAndQuery is failing #23156

Closed majetideepak closed 4 months ago

majetideepak commented 4 months ago

[ERROR] TestPrestoNativeIcebergTpcdsQueriesParquetUsingThrift.doDeletesAndQuery:399->verifyDeletes:390->AbstractTestQueryFramework.computeScalar:149->AbstractTestQueryFramework.computeActual:139 ? Runtime size <= capacity_ (18446744073709551499 vs. 1440) Split [Hive: file:/tmp/iceberg_data/HIVE/tpcds/store_sales/data/593eb530-2b2c-4b34-8bf9-caba66ad83d3.parquet 0 - 2071074] Task 20240709_152552_00114_sdniy.1.0.0.0 Operator: TableScan[0] 0 [INFO] [ERROR] Tests run: 132, Failures: 1, Errors: 0, Skipped: 0

The test started failing with this PR merge https://github.com/prestodb/presto/pull/23138

zacw7 commented 4 months ago

looking

zacw7 commented 4 months ago

The breaking change is https://github.com/facebookincubator/velox/pull/10261 @yingsu00 Could you please help fix this test?

nmahadevuni commented 4 months ago

I will fix this.

tanjialiang commented 4 months ago

I will fix this.

We are reverting https://github.com/facebookincubator/velox/pull/10261 @zacw7 identified, followed up by an advance PR.

zacw7 commented 4 months ago

https://github.com/prestodb/presto/pull/23170 is merged and the test no longer fails. Closing the issue. Thanks!