search

prestodb / presto

The official home of the Presto distributed SQL query engine for big data
http://prestodb.io
Apache License 2.0
16.06k stars 5.38k forks source link

[native] Removing status message from native worker to support http/2 #23653

Closed amitkdutta closed 2 months ago

amitkdutta commented 2 months ago

HTTP/2 does not use status message. We recently migrated to new jetty server that uses http2 (https://github.com/prestodb/presto/pull/23356). From native worker, passing status message is no op. In some cases we parse the error message and pick the first line as message. This is not necessary as status message is not used. Proxygen's RequestBuilder::status function expects status message and sets http version 1/1 hard coded. However, after discussing with proxygen folks, found that they intentially set it and proxygen does not depend on this version number, instead they use server next protocol/client next protocol.

Extensive testing is done with shadow tests, also existing e2e tests pass.

== NO RELEASE NOTE ==
facebook-github-bot commented 2 months ago

@amitkdutta has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.