prestodb / presto

The official home of the Presto distributed SQL query engine for big data
http://prestodb.io
Apache License 2.0
16.07k stars 5.38k forks source link

Move Delete TableWriter TableFinish node to SPI #24088

Closed feilong-liu closed 3 days ago

feilong-liu commented 5 days ago

Description

We are adding a new connector optimizer, however the connector optimizer can only access a limited set of plan nodes which are in the SPI directory. In this PR, I move the DeleteNode, TableWriter and TableFinish node to SPI so that they can be used in collector optimizer.

Most part of the change is refactoring the import path for these nodes. Meaningful change is to get rid of functions not available in SPI, mainly Guava libraries, and replace them with java builtin collection methods.

Motivation and Context

To make DeleteNode, TableWriter and TableFinish nodes available in connector optimizer

Impact

Move Delete TableWriter TableFinish node to SPI

Test Plan

Existing unit tests

Contributor checklist

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== RELEASE NOTES ==

General Changes
* Add Delete TableWriter TableFinish node to SPI :pr:`24088`
steveburnett commented 4 days ago

Thanks for the release note entry! Please revise it to follow the Order of changes in the Release Note Guidelines to begin the line with Fix, Improve, and so on.