prestodb / presto

The official home of the Presto distributed SQL query engine for big data
http://prestodb.io
Apache License 2.0
16.07k stars 5.38k forks source link

Drop getPreferredShuffleLayout methods from SPI #24106

Closed arhimondr closed 2 days ago

arhimondr commented 4 days ago

Description

Use getNewTableLayout/getInsertLayout instead as they are expected to be mutually exclusive with getPreferredShuffleLayout*

Motivation and Context

The preferredShuffleLayout SPI was introduced as an experimental one. The optimizer expects either preferredShuffleLayout or getInsertLayout/ getNewTableLayout to return an non empty layout, but not both.

Impact

Some custom connectors may need to apply a migration

Test Plan

CI

Contributor checklist

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== RELEASE NOTES ==

SPI Changes
* Remove experimental getPreferredShuffleLayout methods from the connector metadata in favor of existing `getNewTableLayout`, `getInsertLayout` methods :pr:`12345`
prestodb-ci commented 2 days ago

Saved that user @arhimondr is from Meta