search

prestodb / prestodb.github.io

Presto website
http://prestodb.github.io/
Apache License 2.0
6 stars 67 forks source link

Remove gh-release job in publish workflow #256

Closed dnskr closed 11 months ago

dnskr commented 11 months ago

The workflow automatically releases website to GitHub Pages by running yarn run publish-gh-pages command. ~The workflow should be deleted, because GitHub Pages is not used anymore to host the website,~ Job gh-release in publish workflow should be deleted, because GitHub Pages is not used anymore to host the website.

dnskr commented 11 months ago

@mcknightd Do you know what is the website deployment flow now?

@wanglinsong I think current workflow should be deleted in any way, because it also breaks Presto Helm chart repository.

wanglinsong commented 11 months ago

How does it break Helm repo?

dnskr commented 11 months ago

Repository presto-helm-charts uses GitHub Pages to host and expose Helm index.yaml to internet.

When the pipeline runs in this repository, it enables GitHub Pages in it and sets Custom domain to prestodb.io to redirect requests from default prestodb.github.io to prestodb.io. It affects all GitHub Pages of prestodb org, so https://prestodb.github.io/presto-helm-charts/ also redirected to https://prestodb.io/presto-helm-charts/, but there is no https://prestodb.github.io/presto-helm-charts/index.xml there. It's fixed manually now (Custom domain was deleted), but the issue could appears again on next commit to this repo.

wanglinsong commented 11 months ago

Can you only remove gh-release?

dnskr commented 11 months ago

@wanglinsong Do you mean remove gh-release job, but leave checks job?