prestodb / testing-mysql-server

Embedded MySQL server for use in tests
Apache License 2.0
1 stars 7 forks source link

Creating testing-mysql-server-8 for prestodb #23

Open Akanksha-kedia opened 10 months ago

Akanksha-kedia commented 10 months ago

Update MySQL JDBC driver to 8.2.0

Note: This artifact was moved to:

com.mysql » mysql-connector-j

MySQL Connector/J artifacts moved to reverse-DNS compliant Maven 2+ coordinates.

image

The upgrade is necessary due to the discovery of direct vulnerabilities in the earlier version of the driver, as listed below: Direct vulnerabilities: CVE-2022-21363 CVE-2019-2692 CVE-2018-3258

Impact The component impacted by this update is presto-mysql. However, the impact is not significant and should not affect the overall functionality or performance.

link : https://github.com/prestodb/presto/pull/21541

Motivation : Need a new version of this dependency for version 8 so PRESTODB tests and prod are consistent.

Akanksha-kedia commented 10 months ago
Screenshot 2024-01-03 at 9 55 26 AM

M1 mac

Akanksha-kedia commented 10 months ago

@tdcmeehan @caithagoras @rschlussel

tdcmeehan commented 10 months ago

This looks like an issue on your Mac setup and may require some deep debugging.

Akanksha-kedia commented 9 months ago

@agrawalreetika https://github.com/prestodb/presto/issues/21845 i have raised issue and was working on it, please review and comment.

ZacBlanco commented 3 weeks ago

PR #24 for the java 21 upgrade fixes the build script and increases the mysql version to 8.4.2.

agrawalreetika commented 2 weeks ago

Hi @ZacBlanco Just wanted to confirm with Java 21 upgrade we are covering MySQL upgrade for both presto and MySQL testing server repos?

https://github.com/prestodb/presto/issues/21845

ZacBlanco commented 2 weeks ago

I haven't tested moving the mysql driver version higher yet. I think I think as part of the upgrade work we are trying to minimize the footprint as much as possible. If we find that we must pull up mysql to get tests passing, then we will do it

agrawalreetika commented 2 weeks ago

Sounds good then may be once testing-mysql-server is upgraded we can then do drive upgrade in presto repo as well.