prestodb / tsc

Presto Foundation TSC
https://prestodb.io
Apache License 2.0
7 stars 33 forks source link

Initial CONTRIBUTING.md file #10

Closed brianwarner closed 4 years ago

brianwarner commented 4 years ago

This is the initial commit of the CONTRIBUTING.md file, which outlines the roles of the project, the names of current committers, and various policies that contributors should be aware of.

Signed-off-by: Brian Warner brian@bdwarner.com

nezihyigitbasi commented 4 years ago

Overall LGTM. It would be good to squash the commits into one before merging as this is just introducing a new file.

brianwarner commented 4 years ago

@aweisberg, sure, here's the logic behind pushing that draft to the tsc repo. Assuming these policies will apply to all repos in the project (per the technical charter), it's generally a good idea to have them in the tsc repo since the TSC is responsible for maintaining them. This also reduces the likelihood that the same text will be replicated across multiple repos - and invariably get out of sync with upstream :-)

As for your other comment on it being light on content - I totally agree, and I appreciate you pulling up the links to the other projects. I put this together as a stub, so that the technical details could be fleshed out by project contributors who are more knowledgeable than me.

nezihyigitbasi commented 4 years ago

@aweisberg @brianwarner Should me just merge this and ask the committers to send follow-up PRs to add the technical aspects? How do we want to proceed here?

brianwarner commented 4 years ago

@nezihyigitbasi I think that would work well, in light of the comment that it's light on content. This gives us a base to build from.

When we're confident that it's been reviewed enough times, then I'd recommend it be moved into the .github repo, so that it's mirrored across all repos.

caniszczyk commented 4 years ago

This pull request should really go to this repo: https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md

Thanks @brianwarner

brianwarner commented 4 years ago

Yep, if I recall correctly, we'd intended to move this one into the .github repo once it lands and is stabilized, so that it could appear uniformly across all the repos. The plan was then to selectively remove the CONTRIBUTING files from repos (because the presence of a CONTRIBUTING.md file overrides the default, and removing the local CONTRIBUTING will cause this one to appear).

Per @caniszczyk's comment about moving this out of this repo, I'll save this text but close the PR, and open a PR in the .github repo. I'd like the TSC to explicitly approve landing it, as that action will cause it to appear across that org.

Separately, I'll break out the list of TSC members and submit a PR against this repo. @aweisberg, I'll add Jiexi and Shixuan when I do so.

brianwarner commented 4 years ago

Per my earlier comment, the new .github repo is up and running, the contents of this file were PR'd against it, and the list of committers were updated in the README.md. I don't think there's anything else to do here, so I'll close this PR.