search

preston / railroady

Ruby on Rails 3/4/5 model and controller UML class diagram generator. (`brew/port/apt-get install graphviz` before use!)
Other
1.72k stars 142 forks source link

Fix model diagram to not show ActiveRecord::Base as an inherited object #108

Closed jazzarati closed 8 years ago

jazzarati commented 8 years ago

When generating model diagrams with inheritance on, ActiveRecord::Base was being displayed on the diagram. The original code looks like it is trying to filter out ActiveRecord::Base but in the course of development maybe it got broken. This PR fixes this so ActiveRecord::Base is filtered out during inheritance generation.

Also this will assist with https://github.com/preston/railroady/issues/90

If this wasn't the desired behaviour that ActiveRecord::Base and CouchRest::Model::Base be excluded then this PR can be ignored. Those desiring equivalent functionality could look at implementing a list of classes (not files) that would be excluded during generation.

preston commented 8 years ago

Seems reasonable to me.. I also find inclusion of ActiveRecord::Base unnecessary.

preston commented 8 years ago

Release as part of v1.5.0.