search

prestoncabe / dmn-benefit-toolbox

Scaffolding for modeling public benefits' eligibility logic with Decision Model and Notation (DMN)
2 stars 0 forks source link

Fix gaps in fplCalculation decision table #29

Closed prestoncabe closed 3 weeks ago

prestoncabe commented 3 weeks ago 
2024-08-20 22:54:22,837 INFO  [org.kie.kog.cod.dec.DecisionValidation] (build-9) Analysing decision tables in DMN Model 'income' ...
2024-08-20 22:54:22,844 INFO  [org.kie.kog.cod.dec.DecisionValidation] (build-9)  analysis for decision table '[ID: _A3A44893-CA6E-4DAA-B1FC-7FC60F8808A2]':
2024-08-20 22:54:22,844 WARN  [org.kie.kog.cod.dec.DecisionValidation] (build-9)   Gap detected: [ <1, - ]
2024-08-20 22:54:22,844 WARN  [org.kie.kog.cod.dec.DecisionValidation] (build-9)   Gap detected: [ 1, <2023 ]
2024-08-20 22:54:22,845 WARN  [org.kie.kog.cod.dec.DecisionValidation] (build-9)   Gap detected: [ 1, ( 2023 .. 2024 ) ]
2024-08-20 22:54:22,845 WARN  [org.kie.kog.cod.dec.DecisionValidation] (build-9)   Gap detected: [ 1, >2024 ]
2024-08-20 22:54:22,845 WARN  [org.kie.kog.cod.dec.DecisionValidation] (build-9)   Gap detected: [ ( 1 .. 2 ), - ]
2024-08-20 22:54:22,846 WARN  [org.kie.kog.cod.dec.DecisionValidation] (build-9)   Gap detected: [ 2, <2023 ]
2024-08-20 22:54:22,846 WARN  [org.kie.kog.cod.dec.DecisionValidation] (build-9)   Gap detected: [ 2, ( 2023 .. 2024 ) ]
2024-08-20 22:54:22,846 WARN  [org.kie.kog.cod.dec.DecisionValidation] (build-9)   Gap detected: [ 2, >2024 ]
2024-08-20 22:54:22,846 WARN  [org.kie.kog.cod.dec.DecisionValidation] (build-9)   Gap detected: [ ( 2 .. 3 ), - ]
2024-08-20 22:54:22,847 WARN  [org.kie.kog.cod.dec.DecisionValidation] (build-9)   Gap detected: [ 3, <2023 ]
2024-08-20 22:54:22,847 WARN  [org.kie.kog.cod.dec.DecisionValidation] (build-9)   Gap detected: [ 3, ( 2023 .. 2024 ) ]
2024-08-20 22:54:22,847 WARN  [org.kie.kog.cod.dec.DecisionValidation] (build-9)   Gap detected: [ 3, >2024 ]
2024-08-20 22:54:22,847 WARN  [org.kie.kog.cod.dec.DecisionValidation] (build-9)   Gap detected: [ ( 3 .. 4 ), - ]
2024-08-20 22:54:22,848 WARN  [org.kie.kog.cod.dec.DecisionValidation] (build-9)   Gap detected: [ 4, <2023 ]
2024-08-20 22:54:22,848 WARN  [org.kie.kog.cod.dec.DecisionValidation] (build-9)   Gap detected: [ 4, ( 2023 .. 2024 ) ]
2024-08-20 22:54:22,848 WARN  [org.kie.kog.cod.dec.DecisionValidation] (build-9)   Gap detected: [ 4, >2024 ]
2024-08-20 22:54:22,848 WARN  [org.kie.kog.cod.dec.DecisionValidation] (build-9)   Gap detected: [ ( 4 .. 5 ), - ]
2024-08-20 22:54:22,849 WARN  [org.kie.kog.cod.dec.DecisionValidation] (build-9)   Gap detected: [ 5, <2023 ]
2024-08-20 22:54:22,849 WARN  [org.kie.kog.cod.dec.DecisionValidation] (build-9)   Gap detected: [ 5, ( 2023 .. 2024 ) ]
2024-08-20 22:54:22,849 WARN  [org.kie.kog.cod.dec.DecisionValidation] (build-9)   Gap detected: [ 5, >2024 ]
2024-08-20 22:54:22,850 WARN  [org.kie.kog.cod.dec.DecisionValidation] (build-9)   Gap detected: [ ( 5 .. 6 ), - ]
2024-08-20 22:54:22,850 WARN  [org.kie.kog.cod.dec.DecisionValidation] (build-9)   Gap detected: [ 6, <2023 ]
2024-08-20 22:54:22,850 WARN  [org.kie.kog.cod.dec.DecisionValidation] (build-9)   Gap detected: [ 6, ( 2023 .. 2024 ) ]
2024-08-20 22:54:22,850 WARN  [org.kie.kog.cod.dec.DecisionValidation] (build-9)   Gap detected: [ 6, >2024 ]
2024-08-20 22:54:22,851 WARN  [org.kie.kog.cod.dec.DecisionValidation] (build-9)   Gap detected: [ ( 6 .. 7 ), - ]
2024-08-20 22:54:22,851 WARN  [org.kie.kog.cod.dec.DecisionValidation] (build-9)   Gap detected: [ 7, <2023 ]
2024-08-20 22:54:22,851 WARN  [org.kie.kog.cod.dec.DecisionValidation] (build-9)   Gap detected: [ 7, ( 2023 .. 2024 ) ]
2024-08-20 22:54:22,852 WARN  [org.kie.kog.cod.dec.DecisionValidation] (build-9)   Gap detected: [ 7, >2024 ]
2024-08-20 22:54:22,852 WARN  [org.kie.kog.cod.dec.DecisionValidation] (build-9)   Gap detected: [ ( 7 .. 8 ), - ]
2024-08-20 22:54:22,852 WARN  [org.kie.kog.cod.dec.DecisionValidation] (build-9)   Gap detected: [ 8, <2023 ]
2024-08-20 22:54:22,853 WARN  [org.kie.kog.cod.dec.DecisionValidation] (build-9)   Gap detected: [ 8, ( 2023 .. 2024 ) ]
2024-08-20 22:54:22,853 WARN  [org.kie.kog.cod.dec.DecisionValidation] (build-9)   Gap detected: [ 8, >2024 ]
2024-08-20 22:54:22,853 WARN  [org.kie.kog.cod.dec.DecisionValidation] (build-9)   Gap detected: [ >8, <2023 ]
2024-08-20 22:54:22,854 WARN  [org.kie.kog.cod.dec.DecisionValidation] (build-9)   Gap detected: [ >8, ( 2023 .. 2024 ) ]
2024-08-20 22:54:22,854 WARN  [org.kie.kog.cod.dec.DecisionValidation] (build-9)   Gap detected: [ >8, >2024 ]
prestoncabe commented 3 weeks ago

@Preston Cabe Do the years have to be numbers? For the income decision table I switched them to strings and it fixed it. My thinking is that it should be treated as a string since since it's more like a label and we don't need to perform any calculations with it. It's just telling us which FPL year to use. Or should I keep as a number data type and update? 2024-08-21 13:39:39,448 WARN [org.kie.kog.cod.dec.DecisionValidation] (build-28) Columns: [year] relate to FEEL string values which can be enumerated for the inputs; Gap analysis skipped.

@sierscse good point about it being more of a label… i think that’s fine! You might want to make a type for “fplYear” and make enumerated options of “2023” and “2024”.