search

prestonp / simple-rcon

Simple, painless node RCON client for Source servers
MIT License
14 stars 4 forks source link

UTF8 Support #18

Closed garrettjoecox closed 6 years ago

garrettjoecox commented 6 years ago

Hey there,

@ lib/packet.js:13,24 you are encoding & decoding using ASCII, rather than the default UTF8. Are there any reasons behind this? This causes issues when sending any non ASCII characters through the RCON packets.

skibz commented 6 years ago

hi @garrettjoecox

if you refer here, the protocol prescribes the use of ascii encoding.

garrettjoecox commented 6 years ago

Ah gotcha, thanks.