pret / pokecrystal

Disassembly of Pokémon Crystal
https://pret.github.io/pokecrystal/
2.07k stars 778 forks source link

Fix definitions for `tempo_relative` and `new_song` #1043

Closed Rangi42 closed 1 year ago

Rangi42 commented 1 year ago

These unused commands have inaccurate macro definitions. tempo_relative takes a bigdw \1 ; tempo adjustment argument, but Music_TempoRelative only reads one signed byte. new_song also takes a bigdw \1 ; id argument, but Music_NewSong reads a little-endian two-byte music ID value. The macros should be updated accordingly.

Idain commented 1 year ago

I might make a PR to help.