pret / pokecrystal

Disassembly of Pokémon Crystal
https://pret.github.io/pokecrystal/
2.07k stars 778 forks source link

Fix RTC overflow comment #1072

Open aaaaaa123456789 opened 1 year ago

aaaaaa123456789 commented 1 year ago

Fixes #1059

Rangi42 commented 1 year ago

From the issue:

also, the RTC overflow bit may want to be defined in constants/hardware_constants.asm

By the way, if you're going to define bit 6 for overflow, you might also want to define bit 7 for on/off.

Want to leave this open til those are ready?

aaaaaa123456789 commented 1 year ago

Sure, why not.

Idain commented 8 months ago

And so it was never resolved.