search

pret / pokecrystal

Disassembly of Pokémon Crystal
https://pret.github.io/pokecrystal/
2.06k stars 770 forks source link

Correct constant for default Mystery Gift decoration #1084

Closed SnorlaxMonster closed 8 months ago

SnorlaxMonster commented 9 months ago

As mentioned in #1082, the previous Mystery Gift macros referred to incorrect decorations.

While most of these were fixed in pokegold#108 (which has already been merged into pokecrystal), it did not include a fix for the default Mystery Gift decoration. As documented by bayleaf on the Project Pokémon forums, the default decoration should be a Red Carpet (not a Polkadot Bed).

Just like the other fixes in pokegold#108, this fix is as simple as replacing the old DECO macro with a DECOFLAG macro.

vulcandth commented 8 months ago

After looking at everything, this looks good to me. Will merge soon when I can merge this to pokegold as well.