search

pret / pokecrystal

Disassembly of Pokémon Crystal
https://pret.github.io/pokecrystal/
2.06k stars 770 forks source link

The `list_start` macro should take a max string length for `li` to check #1086

Closed Rangi42 closed 9 months ago

Rangi42 commented 9 months ago

These macros are used for lists of move names, item names, trainer class names, etc. In most cases they have a maximum string length which would be convenient to enforce.

vulcandth commented 9 months ago

How should li handle things like: li "# BALL"? Should it try to expand out #?

Rangi42 commented 9 months ago

Hmm. That might just make it not worth doing.

vulcandth commented 9 months ago

I'm worried that anything we do to try to expand it out, would mean a user might have the modify the macro if they change the control characters... furthermore if we don't expand it out, then it gives a false sense of safety. So I say lets not do this.