pret / pokecrystal

Disassembly of Pokémon Crystal
https://pret.github.io/pokecrystal/
2.06k stars 770 forks source link

Update to RGBDS 0.7.0 #1101

Closed Rangi42 closed 6 months ago

Rangi42 commented 6 months ago

These new features are used from RGBDS 0.7.0:

Also rgbdscheck.asm is rewritten to be more robust with older versions of RGBDS. (We can't define constants since DEF is required in 0.7.0 but not yet defined in old enough versions; likewise for backslash line continuations, ELIF, etc.)

Note that the object file revision is still 9, so tools/unnamed.py did not need updating.

vulcandth commented 6 months ago

Lets also update the STYLE.md guide to mention we won't be using :: to separate multiple instructions on one line.

Rangi42 commented 6 months ago

STYLE.md was last updated two years ago and may need further changes than that; can we just do it separately?

aaaaaa123456789 commented 6 months ago

Lets also update the STYLE.md guide to mention we won't be using :: to separate multiple instructions on one line.

This sounds unnecessary. This is already something extremely unusual, to the point "don't do it" is the default in basically every programming community for every language — if someone wants to do this, there's probably a very good reason for it.