search

pret / pokecrystal

Disassembly of Pokémon Crystal
https://pret.github.io/pokecrystal/
2.06k stars 770 forks source link

Add defintion for OAM y-Coordinate offscreen value #1108

Closed vulcandth closed 3 months ago

vulcandth commented 6 months ago

Reference: https://gbdev.io/pandocs/OAM.html#byte-0--y-position

Essentially, a y-coord of 160 is the screen's height (144) plus the height of a 8x16 sprite (2 tiles).

mid-kid commented 6 months ago

I'd honestly rather a new constant for this, the math isn't really obvious (OAM_YCOORD_DISABLED or similar, please think of a better name than this)

vulcandth commented 6 months ago

I'd honestly rather a new constant for this, the math isn't really obvious (OAM_YCOORD_DISABLED or similar, please think of a better name than this)

Why come up with a better name when you have a perfectly terrible name right here. LOL

I'll think of something soon.

Rangi42 commented 3 months ago

OAM_YCOORD_HIDDEN? Since they're not disabled, just off-screen.