search

pret / pokecrystal

Disassembly of Pokémon Crystal
https://pret.github.io/pokecrystal/
2.06k stars 770 forks source link

TextCommand_WAIT_BUTTON naming #1109

Open mauvesea opened 5 months ago

mauvesea commented 5 months ago

The comment for the function TextCommand_WAIT_BUTTON suggests the arrow shouldn't be printed, but it calls PromptButton, which prints the arrow.

I believe that command itself is never used, so the issue goes unseen in regular gameplay. The fix to that is just to call WaitButton instead. (Thanks @Idain !)

win-ini commented 5 months ago

are we sure it was meant to call waitbutton, not promptbutton? are we sure the comment is right?

Idain commented 5 months ago

There's already a TextCommand_PROMPT_BUTTON which works perfectly, and the one mentioned in this issue isn't a copy of the first, so there's a good chance it's a bug.

Another chance is that whoever named the function wrongly called it WAIT_BUTTON and not PROMPT_BUTTON_2, but considering most text commands have an equivalent TextCommand_*, this possibility is low.